Update stdarch submodule #74482
Update stdarch submodule #74482
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
The submodule update pulls in rust-lang/stdarch@6a20add, which makes breaking changes to some stable x86(-64) intrinsics. Discussion in the PR (rust-lang/stdarch#868) proposes to do a crater run on the submodule update, which is currently in progress at #73166 so I don't think this PR can be merged yet. |
|
Hm ok, that PR has sat for a few weeks without a lot of activity, but seems ok to wait a little more. If it takes much longer though I think I'll push to revert the breaking change which can be re-landed if crater comes back clean. |
|
☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts. |
This commit partially reverts rust-lang#868 to restore the intrinsics to their original implementation to avoid breaking changes. This is done while rust-lang/rust#73166 is running through crater, and should unblock rust-lang/rust#74482.
|
I've posted rust-lang/stdarch#878 to help this move along. |
This commit partially reverts #868 to restore the intrinsics to their original implementation to avoid breaking changes. This is done while rust-lang/rust#73166 is running through crater, and should unblock rust-lang/rust#74482.
This commit updates the src/stdarch submodule primarily to include rust-lang/stdarch#874 which updated and revamped WebAssembly SIMD intrinsics and renamed WebAssembly atomics intrinsics. This is all unstable surface area of the standard library so the changes should be ok here. The SIMD updates also enable SIMD intrinsics to be used by any program any any time, yay! cc rust-lang#74372, a tracking issue I've opened for the stabilization of SIMD intrinsics
alexcrichton
force-pushed
the
update-stdarch
branch
from
469df4e to
83b4930
Compare
|
Ok re-r? @hanna-kruppe This should no longer be a breaking change for x86/x86_64 |
|
@bors r+ |
|
📌 Commit 83b4930 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
…sfackler Fix an intrinsic invocation on threaded wasm This looks like it was forgotten to get updated in rust-lang#74482 and wasm with threads isn't built on CI so we didn't catch this by accident.
This commit updates the src/stdarch submodule primarily to include
rust-lang/stdarch#874 which updated and revamped WebAssembly SIMD
intrinsics and renamed WebAssembly atomics intrinsics. This is all
unstable surface area of the standard library so the changes should be
ok here. The SIMD updates also enable SIMD intrinsics to be used by any
program any any time, yay!
cc #74372, a tracking issue I've opened for the stabilization of SIMD
intrinsics